[
https://issues.apache.org/jira/browse/HDFS-15032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990272#comment-16990272
]
Konstantin Shvachko commented on HDFS-15032:
--------------------------------------------
Erik. the patch looks good and tests work as expected for me.
I did not understand what you are trying to achieve with method {{toString()}}.
It is a good thing to define it for class {{ProxyCombiner}}, then in debugger I
can see all proxies it combines. But I don't see why invoking {{toString()}} on
say {{ClientProtocol}} should be diverted to {{ProxyCombiner.toString()}}. I
just don't see what is it useful for, but it will do string comparison for all
other calls hurting performance.
> Balancer crashes when it fails to contact an unavailable NN via
> ObserverReadProxyProvider
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-15032
> URL: https://issues.apache.org/jira/browse/HDFS-15032
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Affects Versions: 2.10.0
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HDFS-15032.000.patch, HDFS-15032.001.patch,
> HDFS-15032.002.patch
>
>
> When trying to run the Balancer using ObserverReadProxyProvider (to allow it
> to read from the Observer Node as described in HDFS-14979), if one of the NNs
> isn't running, the Balancer will crash.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
