[ 
https://issues.apache.org/jira/browse/HDFS-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995388#comment-16995388
 ] 

Masatake Iwasaki commented on HDFS-15048:
-----------------------------------------

{quote}it is ok since there is supposed to be just one DirectoryScanner in a 
DataNode except for a test case.
{quote}
Sure. The problems is that {{DataNodeTestUtils#runDirectoryScanner}} calls 
{{DirectoryScanner#reconcile}} from outside. I'd not like to update the 
DirectoryScanner a lot just for test utils. Suppressing the warning should be 
enough.

> Fix findbug in DirectoryScanner
> -------------------------------
>
>                 Key: HDFS-15048
>                 URL: https://issues.apache.org/jira/browse/HDFS-15048
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Takanobu Asanuma
>            Assignee: Masatake Iwasaki
>            Priority: Major
>         Attachments: HDFS-15048.001.patch
>
>
> There is a findbug in DirectoryScanner.
> {noformat}
> Multithreaded correctness Warnings
> org.apache.hadoop.hdfs.server.datanode.DirectoryScanner.reconcile() calls 
> Thread.sleep() with a lock held
> Bug type SWL_SLEEP_WITH_LOCK_HELD (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DirectoryScanner
> In method org.apache.hadoop.hdfs.server.datanode.DirectoryScanner.reconcile()
> At DirectoryScanner.java:[line 441]
> {noformat}
> https://builds.apache.org/job/PreCommit-HDFS-Build/28498/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to