[ https://issues.apache.org/jira/browse/HDFS-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999789#comment-16999789 ]
Xiaoqiao He commented on HDFS-15000: ------------------------------------ Thanks [~Aiphag0], it's a very good start here. Some suggestions, a. Please rebase codebase then submit new patch. b. We should consider case how to rollback meta information of {{volumeMap}} while IoTasker run failed. c. Consider this is core changes, we should add enough unit test to cover changes. > Improve FsDatasetImpl to avoid IO operation in datasetLock > ---------------------------------------------------------- > > Key: HDFS-15000 > URL: https://issues.apache.org/jira/browse/HDFS-15000 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Reporter: Xiaoqiao He > Assignee: Aiphago > Priority: Major > Attachments: HDFS-15000.001.patch > > > As HDFS-14997 mentioned, some methods in #FsDatasetImpl such as > #finalizeBlock, #finalizeReplica, #createRbw includes IO operation in the > datasetLock, It will block some logic when IO load is very high. We should > reduce grain fineness or move IO operation out of datasetLock. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org