[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001045#comment-17001045
]
Íñigo Goiri commented on HDFS-15075:
------------------------------------
I would take this opportunity to improve this in two ways:
* Improve the logging logic
** Instead of having 2000 directly, make it a constant. Ideally it would be a
config key, but I'm ok with just a constant.
** Use the logger format ({}) in the log message.
* Expose these times as a counter. Either using a quantile metric or something
similar. Exposing this through JMX might be valuable if you had experience
issues with this in the past.
> Remove process command timing from BPServiceActor
> -------------------------------------------------
>
> Key: HDFS-15075
> URL: https://issues.apache.org/jira/browse/HDFS-15075
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Íñigo Goiri
> Assignee: Xiaoqiao He
> Priority: Major
> Attachments: HDFS-15075.001.patch
>
>
> HDFS-14997 moved the command processing into async.
> Right now, we are checking the time to add to a queue.
> We should remove this one and maybe move the timing within the thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
