[ 
https://issues.apache.org/jira/browse/HDFS-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001814#comment-17001814
 ] 

Ayush Saxena commented on HDFS-15076:
-------------------------------------

Thanx [~shv] for the patch, Overall LGTM, Minor doubt :
{code:java}
+    final boolean[] deleted = new boolean[]{false};{code}
Why array of size 1 rather than just having a single variable.

> Fix tests that hold FSDirectory lock, without holding FSNamesystem lock.
> ------------------------------------------------------------------------
>
>                 Key: HDFS-15076
>                 URL: https://issues.apache.org/jira/browse/HDFS-15076
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Major
>         Attachments: HDFS-15076.001.patch
>
>
> Three tests {{TestGetBlockLocations}}, {{TestFSNamesystem}}, 
> {{TestDiskspaceQuotaUpdate}} use {{FSDirectory}} methods, which hold 
> FSDirectory lock. They should also hold the global Namesystem lock.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to