[ 
https://issues.apache.org/jira/browse/HDFS-15133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031475#comment-17031475
 ] 

hemanthboyina commented on HDFS-15133:
--------------------------------------

thanks for the work [~maobaolong]

i have gone through your commit .

some questions and suggestions

1)
{quote}// TODO(maobaolong): addCodec for INode and INodeWithAdditionalFields 
and all of their sub class.
{quote}
How are you planning to addCodec for INode Objects ?

 I think we need to use serialisation and deserialisation of INodeDirectory and 
INodeFile

2)
{code:java}
    public RocksInodeStore(INodeDirectory rootDir) throws IOException {
        DBStore dbStore = DBStoreBuilder.newBuilder(new 
OzoneConfiguration()).setName("inode.db")
            .setPath(Paths.get("./"))
            .build(); {code}
we have to add our INodeTable as
{code:java}
  DBStore dbStore = DBStoreBuilder.newBuilder(new 
OzoneConfiguration()).setName("inode.db")
            .setPath(Paths.get("./")).addTable("inodeTable")
            .build();{code}
3) While Intialising RocksINodeStore , First we have to put Root INodeDirectory 
into the INodeTable . 

> Use rocksdb to store NameNode inode and blockInfo
> -------------------------------------------------
>
>                 Key: HDFS-15133
>                 URL: https://issues.apache.org/jira/browse/HDFS-15133
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.3.0
>            Reporter: maobaolong
>            Priority: Major
>         Attachments: image-2020-01-28-12-30-33-015.png
>
>
> Maybe we don't need checkpoint to a fsimage file, the rocksdb checkpoint can 
> achieve the same request.
> This is ozone and alluxio way to manage meta data of master node.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to