[ 
https://issues.apache.org/jira/browse/HDFS-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033996#comment-17033996
 ] 

Konstantin Shvachko commented on HDFS-15111:
--------------------------------------------

Sorry I got distracted from this.
I think you got confused by the name of the method {{stopStandbyServices()}}. 
It is actually stopping non-active services. Other HAServiceStates 
{{INITIALIZING}} and {{STOPPING}} don't have corresponding HAState classes. 
{{INITIALIZING}} essentially stands for {{HAState == null}} and {{STOPPING}} is 
minimally used in HDFS.
I am fine printing "standby" instead of those if feel strong, but it is kinda 
confusing.

> stopStandbyServices() should log which service state it is transitioning from.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-15111
>                 URL: https://issues.apache.org/jira/browse/HDFS-15111
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs, logging
>    Affects Versions: 2.10.0
>            Reporter: Konstantin Shvachko
>            Assignee: Xieming Li
>            Priority: Major
>              Labels: newbie++
>         Attachments: HDFS-15111.001.patch, HDFS-15111.002.patch, 
> HDFS-15111.003.patch
>
>
> Trying to transition Observer to Standby state. {{stopStandbyServices()}} 
> logs that it is "Stopping services started for standby state". It should be 
> "Stopping services started for observer state"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to