[ 
https://issues.apache.org/jira/browse/HDFS-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160535#comment-13160535
 ] 

Eli Collins commented on HDFS-2430:
-----------------------------------

bq. It only throws an RTE if the configured number of redundant resources is 
less than the configured minimum number of redundant resources. i.e. it throws 
only in the case of misconfiguration. If indeed the number of configured 
redundant resources is greater than the minimum, but the number of available 
redundant resources is below the minimum, the method will return false. Does 
that seem reasonable?

Ah, I think it would be more clear if the static (configuration) one-time check 
was separated from the dynamic check (eg so you don't have to check all callers 
to reason about the method) but I don't feel strongly. If you keep the current 
behavior please add a throws clause to the javadoc and add a comment per your 
above explanation. If you want to address it feel free to do so in a follow on 
jira.  +1 to the latest patch.


                
> The number of failed or low-resource volumes the NN can tolerate should be 
> configurable
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-2430
>                 URL: https://issues.apache.org/jira/browse/HDFS-2430
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-2430.patch, HDFS-2430.patch, HDFS-2430.patch, 
> HDFS-2430.patch
>
>
> Currently the number of failed or low-resource volumes the NN can tolerate is 
> effectively hard-coded at 1. It would be nice if this were configurable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to