[ https://issues.apache.org/jira/browse/HDFS-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-2616: ------------------------------ Attachment: hdfs-2616-addendum.txt Needed a slight addendum here for the mocking of DatanodeProtocol in TestBPOfferService. It was previously returning null which was treated as "no commands", but now that triggers an NPE in the tests. I'll commit this trivial fix in a few minutes. > Change DatanodeProtocol#sendHeartbeat to return HeartbeatResponse > ----------------------------------------------------------------- > > Key: HDFS-2616 > URL: https://issues.apache.org/jira/browse/HDFS-2616 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: data-node, name-node > Affects Versions: HA branch (HDFS-1623) > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Fix For: HA branch (HDFS-1623) > > Attachments: HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, > HDFS-2616.txt, HDFS-2616.txt, HDFS-2616.txt, hdfs-2616-addendum.txt > > > DatanodeProtocol#sendHeartbeat() returns DatanodeCommand[]. This jira > proposes changing it to to return HeartbeatResponse that has > DatanodeCommand[]. This allows adding other information that can be returned > by the namenode to the datanode, instead of having to only return > DatanodeCommand[]. For relevant discussion see HDFS-1972. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira