[
https://issues.apache.org/jira/browse/HDFS-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059078#comment-17059078
]
Íñigo Goiri commented on HDFS-15221:
------------------------------------
Thanks [~hadoop_yangyun] for the patch.
A few minor comments:
* I think the key ({{dfs.datanode.volume.storagetype.XX}}) should be defined
somewhere else. HdfsConfiguration or something like this.
* We should add a javadoc to StorageType#getConf().
* Not sure about the StorageType#toLowerCase() for the config key.
* Use logger format ({}) in the logs of DataNode.
* Add a comment to the new block in instantiateDataNode().
* The continue part in instantiateDataNode() is a little hard to read. That
whole block could be improved, maybe extracting the part where we get
effectiveFs.
* In the assertEquals, the expected value should be the first arg.
* Add comments to testDataDirArchive on the high level ideas of each block.
> Add checking of effective filesystem during initializing storage locations
> --------------------------------------------------------------------------
>
> Key: HDFS-15221
> URL: https://issues.apache.org/jira/browse/HDFS-15221
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15221-002.patch, HDFS-15221.patch
>
>
> We sometimes mount different disks for different storage types as the storage
> location. It's important to check the volume is mounted rightly before
> initializing storage locations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
