[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064329#comment-17064329
]
Íñigo Goiri commented on HDFS-15075:
------------------------------------
Thanks [~hexiaoqiao] for the updated patch.
Good call on the doc file.
After checking more, I have a few minor comments... sorry for bringing them up
late:
* The finally block in the new TestDataNodeMetrics test, should be expanded.
Usually, Yetus would complain.
* Add a few basic comments to the new test (e.g., "Write into a file to trigger
DN metrics".
* I know that DataNodeMetrics doesn't have javadocs, but given that we have
latencies and millis in some parameters, I would make all of them called
"latency" and to have a javadoc saying is milliseconds (let's do this just for
the new methods).
* Let's move the substraction of the time inside the null checks all over
FsDatasetImpl, there is no point doing the substraction and then not doing
anything if it is null.
> Remove process command timing from BPServiceActor
> -------------------------------------------------
>
> Key: HDFS-15075
> URL: https://issues.apache.org/jira/browse/HDFS-15075
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Íñigo Goiri
> Assignee: Xiaoqiao He
> Priority: Major
> Attachments: HDFS-15075.001.patch, HDFS-15075.002.patch,
> HDFS-15075.003.patch, HDFS-15075.004.patch, HDFS-15075.005.patch,
> HDFS-15075.006.patch
>
>
> HDFS-14997 moved the command processing into async.
> Right now, we are checking the time to add to a queue.
> We should remove this one and maybe move the timing within the thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
