[ https://issues.apache.org/jira/browse/HDFS-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071912#comment-17071912 ]
Jianfei Jiang commented on HDFS-15251: -------------------------------------- I found the new zk state when we update zk dependency of our own HBASE to 3.5, some commands throw or log the unknown state. meanwhile the dependency of HBASE in community has not updated yet. So I check the hdfs code and find this issue. I am not sure the the closed state should act like disconnect or expired. So I add two patches and i am puzzled. when zkfc will close the connection actively. If only the moment of graceful shutdown(i will build 3.3.0-snapshot version to make sure if it actually do close at the shutdown) close the connection, it may be unnecessary to rejoin a election as its target is just to shutdown. > Add new zookeeper event type case after zk updated to 3.5.x > ----------------------------------------------------------- > > Key: HDFS-15251 > URL: https://issues.apache.org/jira/browse/HDFS-15251 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Affects Versions: 3.3.0 > Reporter: Jianfei Jiang > Assignee: Jianfei Jiang > Priority: Major > Attachments: HDFS-15251.001.patch, HDFS-15251.002.patch > > > In zookeeper 3.5.x, KeeperState add a new one named Closed, so should add > Close case to the swich as it is not an unexpected Zookeeper watch event > state. > {code:java} > /** @deprecated */ > @Deprecated > Unknown(-1), > Disconnected(0), > /** @deprecated */ > @Deprecated > NoSyncConnected(1), > SyncConnected(3), > AuthFailed(4), > ConnectedReadOnly(5), > SaslAuthenticated(6), > Expired(-112), > Closed(7);{code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org