[ https://issues.apache.org/jira/browse/HDFS-15276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086397#comment-17086397 ]
hemanthboyina commented on HDFS-15276: -------------------------------------- thanks for the review [~liuml07] {quote}Do you think Preconditions.checkState(removed.equals(child)); is better than checking the ID directly? {quote} yes we can use equals method for checking here have updated the patch fixing your comments , please review > Concat on INodeRefernce fails with illegal state exception > ---------------------------------------------------------- > > Key: HDFS-15276 > URL: https://issues.apache.org/jira/browse/HDFS-15276 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: hemanthboyina > Assignee: hemanthboyina > Priority: Critical > Attachments: HDFS-15276.001.patch, HDFS-15276.002.patch > > > Performing concat operation on INodeRefernce throwing illegal state exception > On verifySrcFiles , the src inode was getting converted to Inodefile > {code:java} > final INode srcINode = iip.getLastINode(); > final INodeFile srcINodeFile = INodeFile.valueOf(srcINode, src);{code} > If this INode is an INodeRefernce , it fails at Preconditions.checkstate as > the child is an refernce but we have converted that as file > {code:java} > INodeDirectory#removeChild > final INode removed = children.remove(i); > Preconditions.checkState(removed == child); {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org