[ https://issues.apache.org/jira/browse/HDFS-14353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089524#comment-17089524 ]
Toshihiko Uchida commented on HDFS-14353: ----------------------------------------- Looks curDn.getXceiverCount() > 1 should be negated in TestReconstructStripedFile#testErasureCodingWorkerXmitsWeight as follows. {code} --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReconstructStripedFile.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReconstructStripedFile.java @@ -570,7 +570,7 @@ public void stripedBlockReconstruction() throws IOException { barrier.await(); DataNodeFaultInjector.set(oldInjector); for (final DataNode curDn : cluster.getDataNodes()) { - GenericTestUtils.waitFor(() -> curDn.getXceiverCount() > 1, 10, 60000); + GenericTestUtils.waitFor(() -> curDn.getXceiverCount() <= 1, 10, 60000); assertEquals(0, curDn.getXmitsInProgress()); } } {code} The test failure started to happen after HDFS-14353.007.patch, where GenericTestUtils.waitFor(() -> curDn.getXceiverCount() > 1, 10, 60000) was introduced. > Erasure Coding: metrics xmitsInProgress become to negative. > ----------------------------------------------------------- > > Key: HDFS-14353 > URL: https://issues.apache.org/jira/browse/HDFS-14353 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, erasure-coding > Affects Versions: 3.3.0 > Reporter: maobaolong > Assignee: maobaolong > Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-14353.001.patch, HDFS-14353.002.patch, > HDFS-14353.003.patch, HDFS-14353.004.patch, HDFS-14353.005.patch, > HDFS-14353.006.patch, HDFS-14353.007.patch, HDFS-14353.008.patch, > HDFS-14353.009.patch, screenshot-1.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org