[
https://issues.apache.org/jira/browse/HDFS-15294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092299#comment-17092299
]
Íñigo Goiri commented on HDFS-15294:
------------------------------------
Let's cleanup the checkstyles and findbugs for now.
I need some time to do a careful review on this but minor comments for now:
* The flow in BalanceJob#execute with return and continue is weird, we can get
rid of those and use the jobDone, etc.
* In the toString() methods when using the StringBuilder, don't use + inside
but append().
* Let's use the logger {} format everywhere.
* We should have the documentation right away to make it easier to review.
* Why are we changing the visibility of Router#createRpcServer()? It doesn't
look like is used anywhere.
* Let's add full javadocs to all new public methods at least (ideally even
private). In general, it would be nice to have a fairly descriptive javadoc in
the main entry class.
* Expand all the imports.
> RBF: Balance data across federation namespaces with DistCp and snapshot diff
> ----------------------------------------------------------------------------
>
> Key: HDFS-15294
> URL: https://issues.apache.org/jira/browse/HDFS-15294
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15294.001.patch, HDFS-15294.002.patch,
> distcp-balance.pdf
>
>
> This jira introduces a new balance command 'fedbalance' that is ran by the
> administrator. The process is:
> 1. Use distcp and snapshot diff to sync data between src and dst until they
> are the same.
> 2. Update mount table in Router.
> 3. Delete the src to trash.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
