[ https://issues.apache.org/jira/browse/HDFS-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096944#comment-17096944 ]
Ayush Saxena commented on HDFS-15316: ------------------------------------- Thanx [~hemanthboyina] for the report and patch, code looks fine. * Use of {{WhiteBox}} is deprecated, there is a Jira tracking that too, so better not to use it. Remember Daryn having objections with use of it in one Jira, since it is deprecated. So try using alternatives. * Secondly, can you help when in actual scenario, Deleting last inode will fail, if it actually exist? > Deletion failure should not remove directory from snapshottables > ---------------------------------------------------------------- > > Key: HDFS-15316 > URL: https://issues.apache.org/jira/browse/HDFS-15316 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: hemanthboyina > Assignee: hemanthboyina > Priority: Major > Attachments: HDFS-15316.001.patch > > > If deleting a directory doesn't succeeds , still we are removing directory > from snapshottables > this makes the system inconsistent , we will be able to create snapshots but > snapshot diff throws Directory is not snaphottable -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org