[ https://issues.apache.org/jira/browse/HDFS-15340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107243#comment-17107243 ]
Yiqun Lin commented on HDFS-15340: ---------------------------------- Thanks, [~LiJinglun]. {code} + for (int i = 0; i < recoverIndex; i++) { + // All procedures before recoverProcedure shouldn't be executed. + assertFalse(recoveredProcedures.get(i).getExecuted()); + } + for (int i = recoverIndex; i < procedures.length; i++) { + // All procedures start from recoverProcedure should be executed. + assertTrue(recoveredProcedures.get(i).getExecuted()); + } {code} Not fully get this. Here we have procedures like this 1st procedure -> 2nd procedure -> .. -> recoveredProcedure -> .. ->. Why not is following? Maybe I am missing something, : ). {code} + for (int i = 0; i < recoverIndex; i++) { + assertTrue(recoveredProcedures.get(i).getExecuted()); + } + for (int i = recoverIndex; i < procedures.length; i++) { + assertFalse(recoveredProcedures.get(i).getExecuted()); + } {code} I catch one place seems not correct. {code} + if (currentProcedureName.equals(NEXT_PROCEDURE_NONE)) { + curProcedure = null; + } else { + curProcedure = procedureTable.get(currentProcedureName); + } + String lastProcedureName = Text.readString(in); + if (lastProcedureName.equals(NEXT_PROCEDURE_NONE)) { + lastProcedure = null; + } else { + lastProcedure = procedureTable.get(currentProcedureName); <-- should be lastProcedureName I think + } {code} Others looks good to me. [~ayushtkn], [~elgoiri], would you mind doing additional review for this? I will hold off the commit for few days. Thanks. > RBF: Implement BalanceProcedureScheduler basic framework > -------------------------------------------------------- > > Key: HDFS-15340 > URL: https://issues.apache.org/jira/browse/HDFS-15340 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Jinglun > Assignee: Jinglun > Priority: Major > Attachments: HDFS-15340.001.patch, HDFS-15340.002.patch, > HDFS-15340.003.patch, HDFS-15340.004.patch, HDFS-15340.005.patch, > HDFS-15340.006.patch, HDFS-15340.007.patch > > > Patch in HDFS-15294 is too big to review so we split it into 2 patches. This > is the first one. Detail can be found at HDFS-15294. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org