[ https://issues.apache.org/jira/browse/HDFS-15355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111252#comment-17111252 ]
Íñigo Goiri commented on HDFS-15355: ------------------------------------ Thanks [~hadoop_yangyun] for the update, this looks way more maintainable. * In createDefaultSuite(), the code block at the end, let's make it a private function and return instead of break. * Is there any doc/md file we should extend? * Let's extend the javadocs for the new enum. In the enum one itself we should explain that this wraps the others for example. > Make the default block storage policy ID configurable > ----------------------------------------------------- > > Key: HDFS-15355 > URL: https://issues.apache.org/jira/browse/HDFS-15355 > Project: Hadoop HDFS > Issue Type: Improvement > Components: block placement, namenode > Reporter: Yang Yun > Assignee: Yang Yun > Priority: Minor > Attachments: HDFS-15355.001.patch, HDFS-15355.002.patch, > HDFS-15355.003.patch, HDFS-15355.004.patch, HDFS-15355.005.patch, > HDFS-15355.006.patch, HDFS-15355.007.patch, HDFS-15355.008.patch, > HDFS-15355.009.patch > > > Make the default block storage policy ID configurable. Sometime we want to > use different storage policy ID from the startup of cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org