[ https://issues.apache.org/jira/browse/HDFS-15368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115785#comment-17115785 ]
Ayush Saxena commented on HDFS-15368: ------------------------------------- Tried this with Addendum patch of HDFS-13183, It works well. The new trace is due to HDFS-13183 only I suppose. The v002 should be good to go, once HDFS-13183 is concluded. I have verified locally. Will wait for that to conclude and then retrigger build here to confirm then push if everything seems fine. > TestBalancerWithHANameNodes#testBalancerWithObserver failed occasionally > ------------------------------------------------------------------------ > > Key: HDFS-15368 > URL: https://issues.apache.org/jira/browse/HDFS-15368 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Xiaoqiao He > Assignee: Xiaoqiao He > Priority: Major > Labels: balancer, test > Attachments: HDFS-15368.001.patch, HDFS-15368.002.patch, > TestBalancerWithHANameNodes.testBalancerObserver.log, > TestBalancerWithHANameNodes.testBalancerObserver.log > > > When I am working on HDFS-13183, I found that > TestBalancerWithHANameNodes#testBalancerWithObserver failed occasionally, > because the following code segment. Consider there are 1 ANN + 1 SBN + 2ONN, > when invoke getBlocks with opening Observer Read feature, it could request > any one of two ObserverNN based on my observation. So only verify the first > ObserverNN and check times of invoke #getBlocks is not expected. > {code:java} > for (int i = 0; i < cluster.getNumNameNodes(); i++) { > // First observer node is at idx 2, or 3 if 2 has been shut down > // It should get both getBlocks calls, all other NNs should see 0 > calls > int expectedObserverIdx = withObserverFailure ? 3 : 2; > int expectedCount = (i == expectedObserverIdx) ? 2 : 0; > verify(namesystemSpies.get(i), times(expectedCount)) > .getBlocks(any(), anyLong(), anyLong()); > } > {code} > cc [~xkrogen],[~weichiu]. I am not very familiar for Observer Read feature, > would you like give some suggestions? -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org