[
https://issues.apache.org/jira/browse/HDFS-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121517#comment-17121517
]
Jinglun commented on HDFS-15346:
--------------------------------
Hi [~linyiqun], thanks your great comments ! Yes it is a big patch, very
thankful for reviewing this ! Shoot all the suggestions and upload v05.
{quote}line 132: Why the default bandwidth is only 1 for fedbaalance, will not
be too small?
{quote}
Yes it's too small. I make the default to 10.
{quote}We don't need to use nnUri here because we have already got the
Filesystem instance. If we don't want to specified for one namespace, URI
prefix can be ignored, default fs will be used.
{quote}
I was using the nnUri because when the TrashProcedure is ran in
DistCpFedBalance, the source path and dst path are full paths with the cluster
information. Simplify to use the default fs is also ok as using the URI prefix
is not intuitive. I change it to the simple way.
> RBF: DistCpFedBalance implementation
> ------------------------------------
>
> Key: HDFS-15346
> URL: https://issues.apache.org/jira/browse/HDFS-15346
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15346.001.patch, HDFS-15346.002.patch,
> HDFS-15346.003.patch, HDFS-15346.004.patch
>
>
> Patch in HDFS-15294 is too big to review so we split it into 2 patches. This
> is the second one. Detail can be found at HDFS-15294.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
