[
https://issues.apache.org/jira/browse/HDFS-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132544#comment-17132544
]
Xiaoqiao He commented on HDFS-12733:
------------------------------------
Thanks [~ayushtkn] for your reviews.
{quote}This block could have pitched in if noShared was empty, Now this will
not happen, Is this desirable?{quote}
If `dfs.namenode.edits.dir` and `dfs.namenode.shared.edits.dir` are both empty,
this logic will be invoke and use DFSConfigKeys.DFS_NAMENODE_EDITS_DIR_DEFAULT
as edits directory by default. The unit test
TestFailureOfSharedDir#testLocalEditsDisabledWithoutSharedEditsDir is just for
this case.
{quote}Shouldn't we check have a check that editsDirs isn't empty as
well?{quote}
The original thought is that we should ignore `noSharedEditDirs` only when it
set empty, rather than ignore it when `shareEditDirs` is not empty.
> Option to disable to namenode local edits
> -----------------------------------------
>
> Key: HDFS-12733
> URL: https://issues.apache.org/jira/browse/HDFS-12733
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode, performance
> Reporter: Brahma Reddy Battula
> Assignee: Xiaoqiao He
> Priority: Major
> Attachments: HDFS-12733-001.patch, HDFS-12733-002.patch,
> HDFS-12733-003.patch, HDFS-12733.004.patch, HDFS-12733.005.patch,
> HDFS-12733.006.patch, HDFS-12733.007.patch, HDFS-12733.008.patch,
> HDFS-12733.009.patch
>
>
> As of now, Edits will be written in local and shared locations which will be
> redundant and local edits never used in HA setup.
> Disabling local edits gives little performance improvement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
