[
https://issues.apache.org/jira/browse/HDFS-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141109#comment-17141109
]
Jinglun edited comment on HDFS-15410 at 6/20/20, 3:23 PM:
----------------------------------------------------------
Hi [~linyiqun], thanks your nice comments !
{quote}Not fully understand why .... From my understanding, this two config
settings is can be removed.
{quote}
Agree with you, I removed the configs.
{quote}Can we rename class name from {{DistCpBalanceOptions}} to
{{FedBalanceOptions}}?
{quote}
Done.
{quote}Can we rename config prefix from
{{hadoop.hdfs.procedure.work.thread.num}} to
{{hdfs.fedbalance.procedure.work.thread.num}}?
{quote}
Done.
{quote}Following description need to be updated here since -router option
doesn't require to inout true or false as a parameter now.
{quote}
Done.
was (Author: lijinglun):
Hi [~linyiqun], thanks your nice comments !
{quote}Not fully understand why .... From my understanding, this two config
settings is can be removed.
{quote}
Agree with you, I removed the configs.
{quote}Can we rename config prefix from
{{hadoop.hdfs.procedure.work.thread.num}} to
{{hdfs.fedbalance.procedure.work.thread.num}}?
{quote}
Done.
{quote}Can we rename config prefix from
{{hadoop.hdfs.procedure.work.thread.num}} to
{{hdfs.fedbalance.procedure.work.thread.num}}?
{quote}
Done.
{quote}Following description need to be updated here since -router option
doesn't require to inout true or false as a parameter now.
{quote}
Done.
> Add separated config file fedbalance-default.xml for fedbalance tool
> --------------------------------------------------------------------
>
> Key: HDFS-15410
> URL: https://issues.apache.org/jira/browse/HDFS-15410
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15410.001.patch, HDFS-15410.002.patch,
> HDFS-15410.003.patch
>
>
> Add a separated config file named fedbalance-default.xml for fedbalance tool
> configs. It's like the ditcp-default.xml for distcp tool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
