[ 
https://issues.apache.org/jira/browse/HDFS-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148020#comment-17148020
 ] 

Íñigo Goiri commented on HDFS-15416:
------------------------------------

+1 on  [^HDFS-15416.001.patch] and the PR.
I think they are the same, right?
Which one do you want to go for?

> DataStorage#addStorageLocations() should add more reasonable information 
> verification.
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-15416
>                 URL: https://issues.apache.org/jira/browse/HDFS-15416
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.1.0, 3.1.1
>            Reporter: jianghua zhu
>            Assignee: jianghua zhu
>            Priority: Major
>         Attachments: HDFS-15416.000.patch, HDFS-15416.001.patch
>
>
> SuccessLocations content is an array, when the number is 0, do not need to be 
> executed again loadBlockPoolSliceStorage ().
> code : 
> try
> {    
> final List<StorageLocation> successLocations = loadDataStorage(   datanode, 
> nsInfo,    dataDirs, startOpt, executor);  
> return loadBlockPoolSliceStorage(   datanode, nsInfo,   successLocations, 
> startOpt, executor); }
> finally
> {     executor.shutdown(); }
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to