[ https://issues.apache.org/jira/browse/HDFS-15448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149396#comment-17149396 ]
Yiqun Lin edited comment on HDFS-15448 at 7/1/20, 12:28 PM: ------------------------------------------------------------ Not sure if it's a right behavior to remove startAll() in DataNode#runDatanodeDaemon. The method BlockPoolManager#startAll is invoked in different places, see attached screenshot. The BlockPoolManager#startAll invoked in runDatanodeDaemon seems used for the test. was (Author: linyiqun): Not sure if it's a right behavior to remove startAll() in DataNode#runDatanodeDaemon. The method BlockPoolManager#startAll is invoked in different places, see attached screenshot. > When starting a DataNode, call BlockPoolManager#startAll() twice. > ----------------------------------------------------------------- > > Key: HDFS-15448 > URL: https://issues.apache.org/jira/browse/HDFS-15448 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.1.1 > Reporter: jianghua zhu > Assignee: jianghua zhu > Priority: Major > Attachments: HDFS-15448.001.patch, HDFS-15448.002.patch, > method_invoke_path.jpg > > > When starting a DataNode, call BlockPoolManager#startAll() twice. > The first call: > BlockPoolManager#doRefreshNamenodes() > private void doRefreshNamenodes( > Map<String, Map<String, InetSocketAddress>> addrMap, > Map<String, Map<String, InetSocketAddress>> lifelineAddrMap) > throws IOException { > ... > startAll(); > ... > } > The second call: > DataNode#runDatanodeDaemon() > public void runDatanodeDaemon() throws IOException { > blockPoolManager.startAll(); > ... > } -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org