[
https://issues.apache.org/jira/browse/HDFS-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166976#comment-13166976
]
Hadoop QA commented on HDFS-2654:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506858/hdfs-2654-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 90 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.fs.http.server.TestHttpFSServer
org.apache.hadoop.lib.servlet.TestServerWebApp
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1679//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1679//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs-httpfs.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1679//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1679//console
This message is automatically generated.
> Make BlockReaderLocal not extend RemoteBlockReader2
> ---------------------------------------------------
>
> Key: HDFS-2654
> URL: https://issues.apache.org/jira/browse/HDFS-2654
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.1, 1.0.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-2654-1.patch, hdfs-2654-2.patch, hdfs-2654-2.patch,
> hdfs-2654-2.patch, hdfs-2654-b1-1.patch, hdfs-2654-b1-2.patch,
> hdfs-2654-b1-3.patch
>
>
> The BlockReaderLocal code paths are easier to understand (especially true on
> branch-1 where BlockReaderLocal inherits code from BlockerReader and
> FSInputChecker) if the local and remote block reader implementations are
> independent, and they're not really sharing much code anyway. If for some
> reason they start to share sifnificant code we can make the BlockReader
> interface an abstract class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
