[ 
https://issues.apache.org/jira/browse/HDFS-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156863#comment-17156863
 ] 

Takanobu Asanuma commented on HDFS-12969:
-----------------------------------------

[~hemanthboyina] Thanks for uploading the patch.

TestDecommission#testListOpenFilesWithType failed when 
{{dfs.namenode.list.openfiles.num.responses}} is not 1 (like 2 or 3). Some 
BLOCKING_DECOMMISSION files are incorrectly listed as ALL_OPEN_FILES.

When NameNode returns ALL_OPEN_FILES(non-blocking) files in batch, NameNode 
must ensure that the files are not included in ALL BLOCKING_DECOMMISSION files 
each time FSNamesystem#listOpenFiles is executed. However, it would require a 
huge amount of calculation. IMHO, implementing this feature seems difficult 
with the current codes. I think NameNode needs to have the list of 
ALL_OPEN_FILES(non-blocking) files in advance.

> DfsAdmin listOpenFiles should report files by type
> --------------------------------------------------
>
>                 Key: HDFS-12969
>                 URL: https://issues.apache.org/jira/browse/HDFS-12969
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.1.0
>            Reporter: Manoj Govindassamy
>            Assignee: Hemanth Boyina
>            Priority: Major
>         Attachments: HDFS-12969.001.patch, HDFS-12969.002.patch
>
>
> HDFS-11847 has introduced a new option to {{-blockingDecommission}} to an 
> existing command 
> {{dfsadmin -listOpenFiles}}. But the reporting done by the command doesn't 
> differentiate the files based on the type (like blocking decommission). In 
> order to change the reporting style, the proto format used for the base 
> command has to be updated to carry additional fields and better be done in a 
> new jira outside of HDFS-11847. This jira is to track the end-to-end 
> enhancements needed for dfsadmin -listOpenFiles console output.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to