[
https://issues.apache.org/jira/browse/HDFS-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167200#comment-13167200
]
Hadoop QA commented on HDFS-2650:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506904/HDFS-2650.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 90 warning messages.
-1 javac. The applied patch generated 43 javac compiler warnings (more
than the trunk's current 40 warnings).
-1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.TestParallelRead
org.apache.hadoop.hdfs.TestCrcCorruption
org.apache.hadoop.hdfs.TestQuota
org.apache.hadoop.hdfs.security.token.block.TestBlockToken
org.apache.hadoop.hdfs.TestFileAppend3
org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure
org.apache.hadoop.hdfs.security.TestDelegationToken
org.apache.hadoop.hdfs.tools.TestGetGroups
org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1684//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1684//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs-httpfs.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1684//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1684//console
This message is automatically generated.
> Replace @inheritDoc with @Override
> -----------------------------------
>
> Key: HDFS-2650
> URL: https://issues.apache.org/jira/browse/HDFS-2650
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Hari Mankude
> Assignee: Hari Mankude
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HDFS-2650.txt, hdfs-2650
>
>
> @Override provides both javadoc from superclass and compile time detection of
> overridden method deletion from superclass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
