[
https://issues.apache.org/jira/browse/HDFS-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174019#comment-17174019
]
Chengwei Wang commented on HDFS-15493:
--------------------------------------
Hi [~sodonnell], thanks for your detailed review.
{quote}Before this change, there may have been some inodes where were only
referred to in references, but those INodes must be in the inode section of the
image. Therefore we will handle all inodes mentioned in the references already
with the change in `loadINodesInSection(...)` and hence should remove the
`fillUpInodeList(...)` call below - do you think that is correct?
{quote}
I think you are absolutely right, the INodeReference was constructed with an
inode get by inodeMap which had been loaded during `loadINodesInSection(...)` ,
so it makes no sense to call `fillUpInodeList(...)` again.
I will remove the redundant call and fix the problems about checkstyle and
JavaDoc.
> Update block map and name cache in parallel while loading fsimage.
> ------------------------------------------------------------------
>
> Key: HDFS-15493
> URL: https://issues.apache.org/jira/browse/HDFS-15493
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Chengwei Wang
> Priority: Major
> Attachments: HDFS-15493.001.patch, HDFS-15493.002.patch,
> HDFS-15493.003.patch, HDFS-15493.004.patch, HDFS-15493.005.patch,
> fsimage-loading.log
>
>
> While loading INodeDirectorySection of fsimage, it will update name cache and
> block map after added inode file to inode directory. It would reduce time
> cost of fsimage loading to enable these steps run in parallel.
> In our test case, with patch HDFS-13694 and HDFS-14617, the time cost to load
> fsimage (220M files & 240M blocks) is 470s, with this patch , the time cost
> reduc to 410s.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
