[ https://issues.apache.org/jira/browse/HDFS-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179285#comment-17179285 ]
liusheng edited comment on HDFS-15098 at 8/18/20, 1:06 AM: ----------------------------------------------------------- [~lindongdong] you can check the previous CI results, if we define an unused method, CI will be unhappy. and I still don't know why there is a compatible issue, the method you said will not be used any place, can you please explain more ? The modification of [OpensslSecureRandom.c|https://github.com/apache/hadoop/pull/2211/files#diff-3ee504e8c2a27c840c39c4496a27cc02] I think is to make OpenSSL interface to support SM4, such as check of the OpenSSL version(SM4 feature require OpenSSL>=1.1.1). was (Author: seanlau): [~lindongdong] you can check the previous CI results, if we define an unused method, CI will be unhappy. and I still don't know why there is a compatible issue, the method you said will not be used any place, can you please explain more ? The modification of [OpensslSecureRandom.c|https://github.com/apache/hadoop/pull/2211/files#diff-3ee504e8c2a27c840c39c4496a27cc02] I think is to make OpenSSL interface to support SM4, such as check of the OpenSSL version(SM4 feature require ). it is > Add SM4 encryption method for HDFS > ---------------------------------- > > Key: HDFS-15098 > URL: https://issues.apache.org/jira/browse/HDFS-15098 > Project: Hadoop HDFS > Issue Type: New Feature > Affects Versions: 3.4.0 > Reporter: liusheng > Assignee: liusheng > Priority: Major > Labels: sm4 > Attachments: HDFS-15098.001.patch, HDFS-15098.002.patch, > HDFS-15098.003.patch, HDFS-15098.004.patch, HDFS-15098.005.patch, > HDFS-15098.006.patch, HDFS-15098.007.patch, HDFS-15098.008.patch, > HDFS-15098.009.patch > > > SM4 (formerly SMS4)is a block cipher used in the Chinese National Standard > for Wireless LAN WAPI (Wired Authentication and Privacy Infrastructure). > SM4 was a cipher proposed to for the IEEE 802.11i standard, but has so far > been rejected by ISO. One of the reasons for the rejection has been > opposition to the WAPI fast-track proposal by the IEEE. please see: > [https://en.wikipedia.org/wiki/SM4_(cipher)] > > *Use sm4 on hdfs as follows:* > 1.Configure Hadoop KMS > 2.test HDFS sm4 > hadoop key create key1 -cipher 'SM4/CTR/NoPadding' > hdfs dfs -mkdir /benchmarks > hdfs crypto -createZone -keyName key1 -path /benchmarks > *requires:* > 1.openssl version >=1.1.1 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org