[
https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198152#comment-17198152
]
Janus Chow edited comment on HDFS-15579 at 9/18/20, 8:01 AM:
-------------------------------------------------------------
-Checked the QA result was not be related to this patch.-
-Removed the patch and TestRpcRouter passed, will check the root cause.-
Interesting, I ran the same TestRouterRpc test several times, some succeeded,
some failed. The result is the same with or without this patch.
So the test error should not be related to this patch.
was (Author: symious):
-Checked the QA result was not be related to this patch.-
Removed the patch and TestRpcRouter passed, will check the root cause.
> RBF: The constructor of PathLocation may got some misunderstanding
> ------------------------------------------------------------------
>
> Key: HDFS-15579
> URL: https://issues.apache.org/jira/browse/HDFS-15579
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: Janus Chow
> Assignee: Janus Chow
> Priority: Minor
> Attachments: HDFS-15579-001.patch, HDFS-15579-002.patch
>
>
> There is a constructor of PathLocation as follows, it's for creating a new
> PathLocation with a prioritised nsId.
>
> {code:java}
> public PathLocation(PathLocation other, String firstNsId) {
> this.sourcePath = other.sourcePath;
> this.destOrder = other.destOrder;
> this.destinations = orderedNamespaces(other.destinations, firstNsId);
> }
> {code}
> When I was reading the code of MultipleDestinationMountTableResolver, I
> thought this constructor was to create a PathLocation with an override
> destination. It took me a while before I realize this is a constructor to
> sort the destinations inside.
> Maybe I think this constructor can be more clear about its usage?
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
