[ https://issues.apache.org/jira/browse/HDFS-15516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199150#comment-17199150 ]
Ayush Saxena commented on HDFS-15516: ------------------------------------- Well the end result should be similar with v003, though not the approach of having a method with EnumSet<flag> as param, may be just one more method, which takes {{String}} as param, and if that isn't null, appends that option to end in the main method, where all the append work is being done. This would make the method generic and allow to add things later from other API's as well. [~hexiaoqiao] do you think, this would be a problem, I think this would be better than changing in the operation name, since most of the parsers would be relying on checking the name(equals)? If the field is in the end, the existing parsers might just ignore, since the current format didn't change.. > Add info for create flags in NameNode audit logs > ------------------------------------------------ > > Key: HDFS-15516 > URL: https://issues.apache.org/jira/browse/HDFS-15516 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Shashikant Banerjee > Assignee: jianghua zhu > Priority: Major > Labels: pull-request-available > Attachments: HDFS-15516.001.patch, HDFS-15516.002.patch, > HDFS-15516.003.patch, HDFS-15516.004.patch, HDFS-15516.005.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently, if file create happens with flags like overwrite , the audit logs > doesn't seem to contain the info regarding the flags in the audit logs. It > would be useful to add info regarding the create options in the audit logs > similar to Rename ops. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org