[ 
https://issues.apache.org/jira/browse/HDFS-15594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201259#comment-17201259
 ] 

Xiaoqiao He commented on HDFS-15594:
------------------------------------

Thanks [~NickyYe] and [~elgoiri], it is useful works IMO. Just one concerns, 
will there be any confuses for end user if BlockThreshold never meet datanode 
threshold will not calculate when start phase?
Anyway, I always thought that BlockThreshold is fair enough for general cases 
of NameNode restart, so +1 for this improvement from my side.

> Lazy calculate live datanodes in safe mode tip
> ----------------------------------------------
>
>                 Key: HDFS-15594
>                 URL: https://issues.apache.org/jira/browse/HDFS-15594
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Ye Ni
>            Assignee: Ye Ni
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Safe mode tip is printed every 20 seconds.
> This change is to calculate live datanodes until reported block threshold is 
> meet.
>  Old 
> {code:java}
> STATE* Safe mode ON. The reported blocks 111054015 needs additional 27902753 
> blocks to reach the threshold 0.9990 of total blocks 139095856. The number of 
> live datanodes 2531 has reached the minimum number 1. Safe mode will be 
> turned off automatically once the thresholds have been reached.{code}
> New 
> {code:java}
> STATE* Safe mode ON. 
> The reported blocks 134851250 needs additional 3218494 blocks to reach the 
> threshold 0.9990 of total blocks 138207947.
> The number of live datanodes is not calculated since reported blocks hasn't 
> reached the threshold. Safe mode will be turned off automatically once the 
> thresholds have been reached.{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to