[ https://issues.apache.org/jira/browse/HDFS-13293?focusedWorklogId=496715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496715 ]
ASF GitHub Bot logged work on HDFS-13293: ----------------------------------------- Author: ASF GitHub Bot Created on: 07/Oct/20 16:11 Start Date: 07/Oct/20 16:11 Worklog Time Spent: 10m Work Description: goiri commented on a change in pull request #2363: URL: https://github.com/apache/hadoop/pull/2363#discussion_r501137208 ########## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java ########## @@ -116,10 +118,13 @@ /** Optional perf monitor. */ private final RouterRpcMonitor rpcMonitor; + private final Configuration clientConf; + /** Pattern to parse a stack trace line. */ private static final Pattern STACK_TRACE_PATTERN = Pattern.compile("\\tat (.*)\\.(.*)\\((.*):(\\d*)\\)"); + private static final String CLIENT_IP_STR = "clientIp"; Review comment: Makes sense, let's just keep in mind HDFS-13248 when doing this. So far it looks like is covered. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 496715) Time Spent: 1h 40m (was: 1.5h) > RBF: The RouterRPCServer should transfer client ip via CallerContext to > NamenodeRpcServer > ----------------------------------------------------------------------------------------- > > Key: HDFS-13293 > URL: https://issues.apache.org/jira/browse/HDFS-13293 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: maobaolong > Assignee: Hui Fei > Priority: Major > Labels: pull-request-available > Attachments: HDFS-13293.001.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Otherwise, the namenode don't know the client's callerContext > This jira focuses on audit log which logs real client ip. Leave locality to > HDFS-13248 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org