[
https://issues.apache.org/jira/browse/HDFS-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214577#comment-17214577
]
Chengwei Wang commented on HDFS-15630:
--------------------------------------
[~elgoiri] Thanks for the review.
{quote}To avoid churn, let's keep the all method signature at the beginning and
add the new one afterwards.
Let's also have a javadoc for both; in the old one just add a comment saying
we take the context from the server.
{quote}
I will add doc to the old method and adjust its position.
{quote}For the test in TestRouterRpc, can we actually check that is not null
and preferably something more specific?
{quote}
Did you mean that we should check the specified value for CallerContext in
TestRouterRpc#testMkdirsWithCallerContext() like this:
{code:java}
String expectContext = "callerContext=clientContext,clientIp:"
+ InetAddress.getLocalHost().getHostAddress();
// Assert the caller context is correct at client side
assertEquals(expectContext, CallerContext.getCurrent().getContext());
// Assert the caller context transfer to server side correctly
for (String line : auditlog.getOutput().split("\n")) {
if (line.contains("src=" + dirPath)) {
assertTrue(line.trim().endsWith(expectContext));
}
}
{code}
> RBF: Fix wrong client IP info in CallerContext when requests mount points
> with multi-destinations.
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-15630
> URL: https://issues.apache.org/jira/browse/HDFS-15630
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: Chengwei Wang
> Assignee: Chengwei Wang
> Priority: Major
> Attachments: HDFS-15630.001.patch, HDFS-15630.002.patch
>
>
> There are two issues about client IP info in CallerContext when we try to
> request mount points with multi-destinations.
> # the clientIp would duplicate in CallerContext when
> RouterRpcClient#invokeSequential.
> # the clientIp would miss in CallerContext when
> RouterRpcClient#invokeConcurrent.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
