[
https://issues.apache.org/jira/browse/HDFS-15624?focusedWorklogId=506272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506272
]
ASF GitHub Bot logged work on HDFS-15624:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/20 16:35
Start Date: 29/Oct/20 16:35
Worklog Time Spent: 10m
Work Description: vinayakumarb commented on a change in pull request
#2377:
URL: https://github.com/apache/hadoop/pull/2377#discussion_r514401987
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/StorageType.java
##########
@@ -33,13 +33,12 @@
@InterfaceAudience.Public
@InterfaceStability.Unstable
public enum StorageType {
- // sorted by the speed of the storage types, from fast to slow
RAM_DISK(true, true),
- NVDIMM(false, true),
SSD(false, false),
DISK(false, false),
ARCHIVE(false, false),
- PROVIDED(false, false);
+ PROVIDED(false, false),
+ NVDIMM(false, true);
Review comment:
I have verified the `getStoragePolicies()` with older clients.
Older clients will get the storage policy but, unknown storage types will be
ignored.
So in this case, ALLNVDIMM storage policy shows empty StorageTypes for older
clients.
May be need to show DEFAULT StorageType instead of ignoring the unknown
StorageTypes. This also can be fixed in a separate Jira. Right now, existing
clients wont be broken on` getStoragePolicies()` call with this change.
So nothing special required for that in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 506272)
Time Spent: 5.5h (was: 5h 20m)
> Fix the SetQuotaByStorageTypeOp problem after updating hadoop
> ---------------------------------------------------------------
>
> Key: HDFS-15624
> URL: https://issues.apache.org/jira/browse/HDFS-15624
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Reporter: YaYun Wang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> HDFS-15025 adds a new storage Type NVDIMM, changes the ordinal() of the enum
> of StorageType. And, setting the quota by storageType depends on the
> ordinal(), therefore, it may cause the setting of quota to be invalid after
> upgrade.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
