[
https://issues.apache.org/jira/browse/HDFS-15667?focusedWorklogId=507976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507976
]
ASF GitHub Bot logged work on HDFS-15667:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/20 06:54
Start Date: 05/Nov/20 06:54
Worklog Time Spent: 10m
Work Description: maobaolong commented on pull request #2437:
URL: https://github.com/apache/hadoop/pull/2437#issuecomment-722182138
Thanks @ferhui @Hexiaoqiao for your review. I have did some debug for your
question.
> This case is same as delete one directory without any children files or
all files are empty?
remove a empty dir, `toRemovedBlocks` isn't `null`, its toDeleteList size is
0.
> when will return null?
Through this screenshot, we can find that if `fileRemoved = -1`, then
`toRemovedBlocks = null`
And when `deleteAllowed(iip)` return false, fileRemoved can be `-1`,
```java
private static boolean deleteAllowed(final INodesInPath iip) {
if (iip.length() < 1 || iip.getLastINode() == null) {
if (NameNode.stateChangeLog.isDebugEnabled()) {
NameNode.stateChangeLog.debug(
"DIR* FSDirectory.unprotectedDelete: failed to remove "
+ iip.getPath() + " because it does not exist");
}
return false;
} else if (iip.length() == 1) { // src is the root
NameNode.stateChangeLog.warn(
"DIR* FSDirectory.unprotectedDelete: failed to remove " +
iip.getPath() + " because the root is not allowed to be
deleted");
return false;
}
return true;
}
```
Through the code of `deleteAllowed`, we can find that when src is the root,
it can return false.
So without this PR, when I execute `bin/hdfs dfs -rm -r /`
I find the confusing auditlog line like following
```
2020-11-05 14:32:53,420 INFO FSNamesystem.audit
(FSNamesystem.java:logAuditMessage(8102)) - allowed=true ugi=mbl
(auth:SIMPLE) ip=/127.0.0.1 cmd=delete src=/ dst=null
perm=null proto=rpc
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 507976)
Time Spent: 1h 20m (was: 1h 10m)
> Audit log record the unexpected allowed result when delete called
> -----------------------------------------------------------------
>
> Key: HDFS-15667
> URL: https://issues.apache.org/jira/browse/HDFS-15667
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 3.2.1, 3.4.0
> Reporter: Baolong Mao
> Assignee: Baolong Mao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
