[ https://issues.apache.org/jira/browse/HDFS-15668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226551#comment-17226551 ]
Hui Fei commented on HDFS-15668: -------------------------------- [~wanghongbing] Thanks for reporting, it looks good! +1 > RBF: Fix RouterRPCMetrics annocation and document misplaced error > ----------------------------------------------------------------- > > Key: HDFS-15668 > URL: https://issues.apache.org/jira/browse/HDFS-15668 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation > Affects Versions: 3.2.0 > Reporter: Hongbing Wang > Assignee: Hongbing Wang > Priority: Minor > Attachments: HDFS-15668.001.patch > > > I found that the description of the two fields: +{{ProxyOpFailureStandby}}+ > and +{{ProxyOpFailureCommunicate}}+ in the > [website|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/Metrics.html#RouterRPCMetrics] > may be misplaced. > When I reviewed the code to see the meaning of the two fields, I found that > their descriptions were indeed misplaced. > _Origin code_: > {code:java} > @Metric("Number of operations to fail to reach NN") > private MutableCounterLong proxyOpFailureStandby; > @Metric("Number of operations to hit a standby NN") > private MutableCounterLong proxyOpFailureCommunicate; > {code} > _They should be_: > {code:java} > @Metric("Number of operations to hit a standby NN") > private MutableCounterLong proxyOpFailureStandby; > @Metric("Number of operations to fail to reach NN") > private MutableCounterLong proxyOpFailureCommunicate; > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org