[
https://issues.apache.org/jira/browse/HDFS-15659?focusedWorklogId=508517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508517
]
ASF GitHub Bot logged work on HDFS-15659:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/20 15:52
Start Date: 06/Nov/20 15:52
Worklog Time Spent: 10m
Work Description: amahussein edited a comment on pull request #2435:
URL: https://github.com/apache/hadoop/pull/2435#issuecomment-723153287
> Thanx @amahussein for taking this up.
> I thought it would be just change in the `MiniDfsCluster`, where we can
make this ignore load conf set, and may be add an additional flag, which
enables it for the tests, which requires it to be true.
> Can you explain me the reason of change in `HdfsConfiguration`?
Thanks @ayushtkn for taking a look at the patch.
I did not change the `HdfsConfiguration`. I added two methods
`DFSTestUtil.newHDFSConfiguration()` and `DFSTestUtil.newConfiguration()`. Then
inside Test code, I replaced all calls of `new Configurations()` and `new
HDFSConfiguration()`.
This implementation maintains the same flow adopted in all the Junit tests.
1- Create a new configuration Object; 2- Set the configuration needed for the
test; 3- pass the configuration to MiniDFSCluster builder.
Overriding the value inside the MiniDFSCluster breaks that common sequence.
My intuition was that setting this flag in the MiniDFSCluster:
- may not work on the long run when, later, this flag needs to be enabled on
the cluster for some test cases.
- overriding the flag in the miniDFSCluster may confuse developers who may
not expect the flag to be overriden during the initialization of the cluster.
- design wise, this implementation maintains the concept of OOP with
`newConfiguration()` and `newHDFSConfiguration()` doing the construction and
the default initialization of the configuration.
Let me know WDYT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 508517)
Time Spent: 1h (was: 50m)
> Set dfs.namenode.redundancy.considerLoad to false in MiniDFSCluster
> -------------------------------------------------------------------
>
> Key: HDFS-15659
> URL: https://issues.apache.org/jira/browse/HDFS-15659
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Akira Ajisaka
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> dfs.namenode.redundancy.considerLoad is true by default and it is causing
> many test failures. Let's disable it in MiniDFSCluster.
> Originally reported by [~weichiu]:
> https://github.com/apache/hadoop/pull/2410#pullrequestreview-516144442
> {quote}
> i've certain seen this option causing test failures in the past.
> Maybe we should turn it off by default in MiniDDFSCluster, and only enable it
> for specific tests.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
