[
https://issues.apache.org/jira/browse/HDFS-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243932#comment-17243932
]
Ayush Saxena commented on HDFS-15221:
-------------------------------------
Thanx [~hadoop_yangyun] for the patch. Had a quick look
Minor comment :
{code:java}
2792 String effectiveFs = getEffectiveFileSystem(
2793 location.getUri().getPath(), conf);
2794 if (!effectiveFs.equals(configFs)) {
{code}
{{effectiveFs}} can be {{NULL}}, you need to have a null check as well. Apart
looks good
> Add checking of effective filesystem during initializing storage locations
> --------------------------------------------------------------------------
>
> Key: HDFS-15221
> URL: https://issues.apache.org/jira/browse/HDFS-15221
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15221-002.patch, HDFS-15221-003.patch,
> HDFS-15221-004.patch, HDFS-15221-005.patch, HDFS-15221-006.patch,
> HDFS-15221-007.patch, HDFS-15221-008.patch, HDFS-15221-009.patch,
> HDFS-15221.patch
>
>
> We sometimes mount different disks for different storage types as the storage
> location. It's important to check the volume is mounted rightly before
> initializing storage locations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
