[ 
https://issues.apache.org/jira/browse/HDFS-15709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244237#comment-17244237
 ] 

Wei-Chiu Chuang commented on HDFS-15709:
----------------------------------------

Patch looks good to me.

Just out of my curiosity, how did you determine the socket leak came from the 
checksum reconstructor? Did you use tools like  File Leak Detector? 
https://file-leak-detector.kohsuke.org/

> Socket file descriptor leak in StripedBlockChecksumReconstructor
> ----------------------------------------------------------------
>
>                 Key: HDFS-15709
>                 URL: https://issues.apache.org/jira/browse/HDFS-15709
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, ec, erasure-coding
>            Reporter: Yushi Hayasaka
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> We found a socket file descriptor leak when we tried to get the checksum of 
> EC file with reconstruction happened during the operation.
> The cause of the leak seems that the StripedBlockChecksumReconstructor does 
> not close StripedReader. Making the reader closed, the CLOSE_WAIT connections 
> are gone.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to