[
https://issues.apache.org/jira/browse/HDFS-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248545#comment-17248545
]
Yiqun Lin commented on HDFS-14558:
----------------------------------
[~fengnanli], thanks for updating the patch, most of the patch looks great.
Just few comments from me:
{noformat}
+| dfs.federation.router.fairness.policy.controller.class |
`org.apache.hadoop.hdfs.server.federation.fairness.DefaultFairnessPolicyController`
| Default handler allocation model to be used if isolation feature is enabled.
|
{noformat}
Here the default value should be
org.apache.hadoop.hdfs.server.federation.fairness.NoRouterRpcFairnessPolicyController.
We can mention DefaultFairnessPolicyController in description if isolation
feature is enabled.
{noformat}
+### Isolation
+
+Isolation and dedicated assignment of RPC handlers across all configured
downstream nameservices.
+
{noformat}
Can we additionally mention one point that the sum of all configured handler
count values must be strictly smaller than the router handlers (configed by
dfs.federation.router.handler.count)?
Please fix one whitespace line warings
{noformat}
hadoop-hdfs-project/hadoop-hdfs-rbf/src/site/markdown/HDFSRouterFederation.md:193:Overall
the isolation feature is exposed via a configuration
dfs.federation.router.handler.isolation.enable. The default value of this
feature will be “falseâ€. Users can also introduce their own fairness policy
controller for custom allocation of handlers to various nameservices.
{noformat}
> RBF: Isolation/Fairness documentation
> -------------------------------------
>
> Key: HDFS-14558
> URL: https://issues.apache.org/jira/browse/HDFS-14558
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: CR Hota
> Assignee: Fengnan Li
> Priority: Major
> Attachments: HDFS-14558.001.patch
>
>
> Documentation is needed to make users aware of this feature HDFS-14090.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
