[
https://issues.apache.org/jira/browse/HDFS-15412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256862#comment-17256862
]
Ayush Saxena commented on HDFS-15412:
-------------------------------------
Well changes are looking fine, I would need to go through them once more though.
{code:java}
317 if (this.scanPeriodMs == 0) {
318 this.scanPeriodMs = conf.scanPeriodMs;
319 }
{code}
can we make the check as <=, in order to handle mis configuration, and may
Secondly :
{code:java}
313 this.scanPeriodMs = TimeUnit.MILLISECONDS.convert(
314 StorageType.getConfLong(datanode.getConf(),
315 ref.getVolume().getStorageType(), "scan.period.hours", 0),
316 TimeUnit.HOURS);
{code}
Why are we passing 0 here as default, Why not {{conf.scanPeriodMs}}?
> Add options to set different block scan period for diffrent StorageType
> -----------------------------------------------------------------------
>
> Key: HDFS-15412
> URL: https://issues.apache.org/jira/browse/HDFS-15412
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15412.001.patch, HDFS-15412.002.patch,
> HDFS-15412.003.patch
>
>
> For some cold data, sometime, we don't want to scan cold data as often as
> hot data. Add options that we can set the scan period time according to
> StorageType.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
