[ 
https://issues.apache.org/jira/browse/HDFS-15793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284468#comment-17284468
 ] 

Ayush Saxena commented on HDFS-15793:
-------------------------------------

Thanx [~hadoop_yangyun] for the patch. I just had a cursory look, (sorry low on 
bandwidth)

Couple of things :

* Will decreasing the thread bother the already running ones? 

* In the test can you check if actaully the threads increased/decreased apart 
from just asserting the output message, or atleast some thing more.

* Here will it be long or int?

{code:java}
+    RemoteMethod method = new RemoteMethod("setBalancerMaxThreads",
+        new Class<?>[] {Long.class}, maxThreads);
{code}

* Possible extending a test for Router too?

 

 

> Add command to DFSAdmin for Balancer max concurrent  threads
> ------------------------------------------------------------
>
>                 Key: HDFS-15793
>                 URL: https://issues.apache.org/jira/browse/HDFS-15793
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer &amp; mover
>            Reporter: Yang Yun
>            Assignee: Yang Yun
>            Priority: Minor
>         Attachments: HDFS-15793.001.patch
>
>
> We have DFSAdmin command '-setBalancerBandwidth' to dynamically change the 
> max number of bytes per second of network bandwidth to be used by a datanode 
> during balancing.  Also add '-setBalancerMaxThreads' to dynamically change 
> the balancer maxThread number which may be used concurrently for moving 
> blocks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to