[ https://issues.apache.org/jira/browse/HDFS-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293593#comment-17293593 ]
Steve Loughran commented on HDFS-15867: --------------------------------------- well, some javadocs and inline comments would be welcome > Make getFileChecksumInternal method more readable > ------------------------------------------------- > > Key: HDFS-15867 > URL: https://issues.apache.org/jira/browse/HDFS-15867 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.2.2 > Reporter: Aref Khandan > Priority: Minor > > It might be help with readability having getFileChecksumInternal method > ecpolicy cheking > [https://github.com/apache/hadoop/blob/1a205cc3adffa568c814a5241e041b08e2fcd3eb/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java#L1845] > more explicit, > currently it is implemented inline, which makes understanding the outcome of > condition harder for future readers. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org