[
https://issues.apache.org/jira/browse/HDFS-15908?focusedWorklogId=569584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569584
]
ASF GitHub Bot logged work on HDFS-15908:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/21 09:06
Start Date: 22/Mar/21 09:06
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #2790:
URL: https://github.com/apache/hadoop/pull/2790#discussion_r598532643
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
##########
@@ -264,9 +264,9 @@ void format(NamespaceInfo nsInfo, boolean force) throws
IOException {
*/
@Override // Closeable
public void close() throws IOException {
- storage.close();
Review comment:
This is because it can throw IOException?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 569584)
Time Spent: 0.5h (was: 20m)
> Possible Resource Leak in org.apache.hadoop.hdfs.qjournal.server.Journal
> ------------------------------------------------------------------------
>
> Key: HDFS-15908
> URL: https://issues.apache.org/jira/browse/HDFS-15908
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Narges Shadab
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We noticed a possible resource leak
> [here|https://github.com/apache/hadoop/blob/cd44e917d0b331a2d1e1fa63fdd498eac01ae323/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java#L266].
> The call to close on {{storage}} at line 267 can throw an exception. If it
> occurs, then {{committedTxnId}} and {{curSegment}} are never closed.
> I'll submit a pull request to fix it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
