[
https://issues.apache.org/jira/browse/HDFS-15911?focusedWorklogId=570255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570255
]
ASF GitHub Bot logged work on HDFS-15911:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/21 06:20
Start Date: 23/Mar/21 06:20
Worklog Time Spent: 10m
Work Description: liuml07 commented on a change in pull request #2794:
URL: https://github.com/apache/hadoop/pull/2794#discussion_r599297317
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
##########
@@ -2309,8 +2310,11 @@ public void testBalancerWithSortTopNodes() throws
Exception {
// Hence, overall total blocks moved by HDFS balancer would be either of
these 2 options:
// a) 2 blocks of total size (100B + 100B)
// b) 3 blocks of total size (50B + 100B + 100B)
- assertTrue(balancerResult.getBytesAlreadyMoved() == 200
- || balancerResult.getBytesAlreadyMoved() == 250);
+ assertTrue(
Review comment:
might be helpful if we add `balancerRestult` into the error message as
the assertion is getting longer; so it will be easier to reason about in case
of test failure. At least it's easier than checking logs in console.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 570255)
Time Spent: 3h 10m (was: 3h)
> Provide blocks moved count in Balancer iteration result
> -------------------------------------------------------
>
> Key: HDFS-15911
> URL: https://issues.apache.org/jira/browse/HDFS-15911
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Balancer provides Result for iteration and it contains info like exitStatus,
> bytesLeftToMove, bytesBeingMoved etc. We should also provide blocksMoved
> count from NameNodeConnector and print it with rest of details in
> Result#print().
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
