[
https://issues.apache.org/jira/browse/HDFS-15931?focusedWorklogId=575918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-575918
]
ASF GitHub Bot logged work on HDFS-15931:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/21 05:35
Start Date: 02/Apr/21 05:35
Worklog Time Spent: 10m
Work Description: virajjasani commented on pull request #2830:
URL: https://github.com/apache/hadoop/pull/2830#issuecomment-812329113
> @virajjasani Just saw you have multiple PRs recently. In Hadoop, the PR
title and git commit subject have format:
>
> ```
> HADOOP-12345. Fix foo. Contributed by Viraj
> ```
>
> So the `.` instead of ` :`. I personally am fine with either char, but
looks like the convention is to have `.` instead of space and colon ` :` to
join the JIRA number and subject.
Thanks @liuml07 , I will take care of this going forward. One question:
`Contributed by user` should be in PR title? Or that is something taken care of
while merging PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 575918)
Time Spent: 2h 20m (was: 2h 10m)
> Fix non-static inner classes for better memory management
> ---------------------------------------------------------
>
> Key: HDFS-15931
> URL: https://issues.apache.org/jira/browse/HDFS-15931
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.1, 3.4.0, 3.1.5, 2.10.2, 3.2.3
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> If an inner class does not need to reference its enclosing instance, it can
> be static. This prevents a common cause of memory leaks and uses less memory
> per instance of the enclosing class.
> Came across DataNodeProperties as a non static inner class defined in
> MiniDFSCluster without holding any implicit reference to MiniDFSCluster.
> Taking this opportunity to find other non-static inner classes that are not
> holding implicit reference to their respective enclosing instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
