[ https://issues.apache.org/jira/browse/HDFS-15980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322539#comment-17322539 ]
Zheng Shao commented on HDFS-15980: ----------------------------------- There are 3 issues: # The metric names in the tests were incorrect; # The tests only checked the metrics of DataNode 0, but one of the metrics, PacketsSlowWriteToMirror, is only updated on 2 of the 3 DataNodes, so this created an indeterministic failure. # The metric PacketsSlowWriteToOsCache was not updated in the test due to the fact that the size of the file was smaller than BlockReceiver.CACHE_DROP_LAG_BYTES > Fix tests for HDFS-15754 Create packet metrics for DataNode > ----------------------------------------------------------- > > Key: HDFS-15980 > URL: https://issues.apache.org/jira/browse/HDFS-15980 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Reporter: Zheng Shao > Assignee: Zheng Shao > Priority: Trivial > > HDFS-15754 introduces 4 new metrics in DataNodeMetrics. However the test > associated with the patch has some bugs. This issue is to fix those bugs in > the tests. > Please note that the non-test code of HDFS-15754 worked fine without any bugs. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org