[
https://issues.apache.org/jira/browse/HDFS-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175807#comment-13175807
]
Hadoop QA commented on HDFS-2722:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508602/HDFS-2722.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 20 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
-1 release audit. The applied patch generated 1 release audit warnings
(more than the trunk's current 0 warnings).
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1738//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1738//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1738//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1738//console
This message is automatically generated.
> HttpFs shouldn't be using an int for block size
> -----------------------------------------------
>
> Key: HDFS-2722
> URL: https://issues.apache.org/jira/browse/HDFS-2722
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HDFS-2722.patch
>
>
> {{./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java:
> blockSize = fs.getConf().getInt("dfs.block.size", 67108864);}}
> Should instead be using dfs.blocksize and should instead be long.
> I'll post a patch for this after HDFS-1314 is resolved -- which changes the
> internal behavior a bit (should be getLongBytes, and not just getLong, to
> gain formatting advantages).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
