[ https://issues.apache.org/jira/browse/HDFS-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329966#comment-17329966 ]
Hadoop QA commented on HDFS-15393: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Logfile || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 23s{color} | | {color:red} https://github.com/apache/hadoop/pull/2055 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | GITHUB PR | https://github.com/apache/hadoop/pull/2055 | | JIRA Issue | HDFS-15393 | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2055/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. > Review of PendingReconstructionBlocks > ------------------------------------- > > Key: HDFS-15393 > URL: https://issues.apache.org/jira/browse/HDFS-15393 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > > I started looking at this class based on [HDFS-15351]. > * Uses {{java.sql.Time}} unnecessarily. Confusing since Java ships with time > formatters out of the box in JDK 8. I believe this will cause issues later > when trying to upgrade to JDK 9+ since SQL is a different module in Java. > * Remove code where appropriate > * Use Java Concurrent library for higher concurrent access to underlying map -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org